On Mon, May 15, 2023 at 04:33:27PM +0900, Michael Paquier wrote:
> On Thu, May 11, 2023 at 09:34:42AM -0400, Bruce Momjian wrote:
> > On Thu, May 11, 2023 at 02:21:22PM +0200, Daniel Gustafsson wrote:
> >> IIRC there were a number of ideas presented in that thread but backwards
> >> compatibility with --role already "taken" made it complicated, so --role
> >> and
> >> --member were the least bad options.
> >>
> >>> At a minimum I would like to apply the attached doc patch to PG 16 to
> >>> improve awkward wording in CREATE ROLE and createuser.
> >>
> >> No objection.
>
> None from here as well.
>
> >> + role. (This in effect makes the new role a <quote>group</quote>.)
> >> While not introduced here, isn't the latter part interesting enough to
> >> warrant
> >> not being inside parenthesis?
> >
> > The concept of group itself is deprecated, which I think is why the
> > parenthesis are used.
>
> Not sure on this one. The original docs come from 58d214e, and this
> sentence was already in there.
True. I have removed the parenthesis in this updated patch.
--
Bruce Momjian <br...@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Embrace your flaws. They make you human, rather than perfect,
which you will never be.
diff --git a/doc/src/sgml/ref/create_role.sgml b/doc/src/sgml/ref/create_role.sgml
index 4a84461b28..7249fc7432 100644
--- a/doc/src/sgml/ref/create_role.sgml
+++ b/doc/src/sgml/ref/create_role.sgml
@@ -285,10 +285,11 @@ in sync when changing the above synopsis!
<term><literal>IN ROLE</literal> <replaceable class="parameter">role_name</replaceable></term>
<listitem>
<para>
- The <literal>IN ROLE</literal> clause lists one or more existing
- roles to which the new role will be immediately added as a new
- member. (Note that there is no option to add the new role as an
- administrator; use a separate <command>GRANT</command> command to do that.)
+ The <literal>IN ROLE</literal> clause causes the new role to
+ be automatically added as a member of the specified existing
+ roles. (Note that there is no option to add the new role as an
+ administrator; use a separate <command>GRANT</command> command
+ to do that.)
</para>
</listitem>
</varlistentry>
@@ -306,9 +307,9 @@ in sync when changing the above synopsis!
<term><literal>ROLE</literal> <replaceable class="parameter">role_name</replaceable></term>
<listitem>
<para>
- The <literal>ROLE</literal> clause lists one or more existing
- roles which are automatically added as members of the new role.
- (This in effect makes the new role a <quote>group</quote>.)
+ The <literal>ROLE</literal> clause causes one or more specified
+ existing roles to be automatically added as members of the new
+ role. This in effect makes the new role a <quote>group</quote>.
</para>
</listitem>
</varlistentry>
diff --git a/doc/src/sgml/ref/createuser.sgml b/doc/src/sgml/ref/createuser.sgml
index c5c74b86a2..58ed111642 100644
--- a/doc/src/sgml/ref/createuser.sgml
+++ b/doc/src/sgml/ref/createuser.sgml
@@ -85,11 +85,10 @@ PostgreSQL documentation
<term><option>--admin=<replaceable class="parameter">role</replaceable></option></term>
<listitem>
<para>
- Indicates a role that will be immediately added as a member of the new
+ Indicates an existing role that will be automatically added as a member of the new
role with admin option, giving it the right to grant membership in the
- new role to others. Multiple roles to add as members (with admin
- option) of the new role can be specified by writing multiple
- <option>-a</option> switches.
+ new role to others. Multiple existing roles can be specified by
+ writing multiple <option>-a</option> switches.
</para>
</listitem>
</varlistentry>
@@ -153,11 +152,10 @@ PostgreSQL documentation
<term><option>--role=<replaceable class="parameter">role</replaceable></option></term>
<listitem>
<para>
- Indicates a role to which this role will be added immediately as a new
- member. Multiple roles to which this role will be added as a member
- can be specified by writing multiple
- <option>-g</option> switches.
- </para>
+ Indicates the new role should be automatically added as a member
+ of the specified existing role. Multiple existing roles can be
+ specified by writing multiple <option>-g</option> switches.
+ </para>
</listitem>
</varlistentry>
@@ -227,9 +225,9 @@ PostgreSQL documentation
<term><option>--member=<replaceable class="parameter">role</replaceable></option></term>
<listitem>
<para>
- Indicates role that will be immediately added as a member of the new
- role. Multiple roles to add as members of the new role can be specified
- by writing multiple <option>-m</option> switches.
+ Indicates the specified existing role should be automatically
+ added as a member of the new role. Multiple existing roles can
+ be specified by writing multiple <option>-m</option> switches.
</para>
</listitem>
</varlistentry>
