On Mon, 15 May 2023 at 14:47, Masahiko Sawada <sawada.m...@gmail.com> wrote: > Thank you for the patch! I think we might want to have tests for it.
Yes, code looks good. But indeed some tests would be great. It seems we forgot to actually do: On Fri, 12 May 2023 at 13:55, Ajin Cherian <itsa...@gmail.com> wrote: > CREATE ROLE regress_alice NOSUPERUSER LOGIN; > CREATE ROLE regress_admin SUPERUSER LOGIN; > ... > > What I see is that as part of tablesync, the trigger invokes an > updates admin_audit which it shouldn't, as the table owner > of alice.test should not have access to the > table admin_audit. This means the table copy is being invoked as the > subscription owner and not the table owner. I think having this as a tap/regress test would be very useful.
