> On 15 May 2023, at 09:45, Michael Paquier <mich...@paquier.xyz> wrote: > On Thu, May 11, 2023 at 11:57:37AM +0200, Daniel Gustafsson wrote:
>> Looking at the snprintf sites made me remember a patchset I worked on last >> year >> (but I don't remember if I ended up submitting); there is no need to build >> one >> of the queries on the stack as it has no variables. The attached 0003 (which >> needs a reindent of the query text) comes from that patchset. I think we >> should do this regardless. > > Not sure that this is an improvement in itself as > get_tablespace_paths() includes QUERY_ALLOC because > executeQueryOrDie() does so, so this could become a problem if > someones decides to copy-paste this code with a query becomes longer > than QUERY_ALLOC once built? Perhaps that's not worth worrying, We already have lots of invocations of executeQueryOrDie which doesn't pass via a QUERY_ALLOC buffer so I don't see any risk with adding one more. -- Daniel Gustafsson
