Hi,

I just found the naming of the ItemId variables is not consistent in
heapam.c. There are 13 'lpp's and 112 'lp's. Technically 'lpp' is correct
as ItemId is a line pointer's pointer and there used to be code like
"++lpp" for line pointer array iteration. Now that all the "++lpp" code has
been removed and there are 100+ more occurrences of 'Ip' than 'lpp', I
suggest we change 'lpp' to 'lp' to make things consistent and avoid
confusion.

Best Regards,
Zian Wang

Attachment: v-1-0001-Rename-lpp-to-lp-in-heapam.c.patch
Description: Binary data

Reply via email to