On Fri, Apr 21, 2023 at 12:02 PM John Naylor
<john.nay...@enterprisedb.com> wrote:
>
> I agree having the new functions in the tree is useful. I also tried running
> the TAP tests in v2, but 001 and 002 fail to run:
>
> Odd number of elements in hash assignment at [...]/Cluster.pm line 2010.
> Can't locate object method "pump_nb" via package
> "PostgreSQL::Test::BackgroundPsql" at [...]
>
> It seems to be complaining about
>
> +my $in = '';
> +my $out = '';
> +my $timeout = IPC::Run::timer($PostgreSQL::Test::Utils::timeout_default);
> +my $background_psql = $node->background_psql('postgres', \$in, \$out,
> $timeout);
>
> ...that call to background_psql doesn't look like other ones that have "key
> => value". Is there something I'm missing?Thanks for reporting. I think that the patch needs to be updated since commit 664d757531e1 changed background psql TAP functions. I've attached the updated patch. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
v3-0001-Add-tests-for-XID-wraparound.patch
Description: Binary data
