> On 27 Mar 2023, at 10:24, Julien Rouhaud <rjuju...@gmail.com> wrote: > > Hi, > > On Wed, Feb 08, 2023 at 05:18:13PM -0500, Tom Lane wrote: >> I pushed the discussed documentation improvements, and changed the >> behavior of "ninja docs" to only build the HTML docs. However, >> I've not done anything about documenting what is the minimum >> ninja version. > > FTR the documented XML_CATALOG_FILES environment variable is only valid for > Intel based machines, as homebrew installs everything in a different location > for M1... > > I'm attaching a patch to make that distinction, hoping that no one else will > have to waste time trying to figure out how to get it working on such > hardware.
LGTM apart from the double // in the export which is easy enough to fix before pushing. +export XML_CATALOG_FILES=/opt/homebrew//etc/xml/catalog For reference on why Homebrew use a different structure on Apple M1 the below issue has more details: https://github.com/Homebrew/brew/issues/9177 -- Daniel Gustafsson