On Mon, Mar 27, 2023 at 11:32 AM Amit Kapila <amit.kapil...@gmail.com> wrote:
> On Mon, Mar 27, 2023 at 7:03 AM Peter Smith <smithpb2...@gmail.com>
> wrote:
> >
> >
> > 1.
> > +# two publications, one publishing through ancestor and another one
> > directly
> > +# publsihing the partition, with different row filters
> > +$node_publisher->safe_psql('postgres',
> > + "CREATE PUBLICATION tap_pub_viaroot_sync_1 FOR TABLE
> > tab_rowfilter_viaroot_part_sync WHERE (a > 15) WITH
> > (publish_via_partition_root)"
> > +);
> > +$node_publisher->safe_psql('postgres',
> > + "CREATE PUBLICATION tap_pub_viaroot_sync_2 FOR TABLE
> > tab_rowfilter_viaroot_part_sync_1 WHERE (a < 15)"
> > +);
> > +
> >
> > 1a.
> > Typo "publsihing"Changed. > > ~ > > > > 1b. > > IMO these table and publication names could be better. > > > > I thought it was confusing to have the word "sync" in these table > > names and publication names. To the casual reader, it looks like these > > are synchronous replication tests but they are not. > > > > Hmm, sync here is for initial sync, so I don't think it is too much of > a problem to understand if one is aware that these are logical > replication related tests. > > > Similarly, I thought it was confusing that 2nd publication and table > > have names with the word "viaroot" when the option > > publish_via_partition_root is not even true. > > > > I think the better names for tables could be > "tab_rowfilter_parent_sync, tab_rowfilter_child_sync" and for > publications "tap_pub_parent_sync_1, > tap_pub_child_sync_1" Changed. And removed "_1" in the suggested publication names. Previously, I added "_1" and "_2" to distinguish between two publications with the same name. However, the publication names are now different, so I think we could remove "_1". Attach the new patch. Regards, Wang Wei
v24-0001-Avoid-syncing-data-twice-for-the-publish_via_par.patch
Description: v24-0001-Avoid-syncing-data-twice-for-the-publish_via_par.patch
