On Sun, Mar 19, 2023 at 1:04 AM Joseph Koshakow <kosh...@gmail.com> wrote: > > The patches in this email should be rebased over master. >
Reviewed 0001 - Looks good to me. The new function is properly placed along with other signed 64 bit functions. All existing calls to int64_multiply_add() have been replaced with the new function and negated the result. Reviewed 0002 + result->day = days; + if (pg_mul_add_s32_overflow(weeks, 7, &result->day)) You don't need to do this, but looks like we can add DAYS_PER_WEEK macro and use it here. The first two patches look good to me; ready for a committer. Can be committed independent of the third patch. Will look at the third patch soon. -- Best Wishes, Ashutosh Bapat
