On Thu, 23 Mar 2023 at 23:30, Bharath Rupireddy
<bharath.rupireddyforpostg...@gmail.com> wrote:
>
> > + ereport(log_replication_commands ? LOG : DEBUG3,
> > + (errmsg("acquired physical replication slot \"%s\"",
> > + slotname)));So this is just a bit of bike-shedding but I don't feel like these log messages really meet the standard we set for our logging. Like what did the acquiring? What does "acquired" actually mean for a replication slot? Is there not any meta information about the acquisition that can give more context to the reader to make this message more meaningful? I would expect a log message like this to say, I dunno, something like "physical replication slot \"%s\" acquired by streaming TCP connection to 192.168.0.1:999 at LSN ... with xxxMB of logs to read" I even would be wondering if the other end shouldn't also be logging a corresponding log and we shouldn't be going out of our way to ensure there's enough information to match them up and presenting them in a way that makes that easy. -- greg
