On Tue, Mar 21, 2023 at 7:59 PM Michael Paquier <mich...@paquier.xyz> wrote: > On Mon, Mar 20, 2023 at 07:56:42AM -0400, Robert Haas wrote: > > Anyone want to comment on this? > > I have not checked the patch in details, but perhaps this needs at > least one test?
Sure. I was sort of hoping to get feedback on the overall plan first, but it's easy enough to add a test so I've done that in the attached version. I've put it in a separate file because 010_pg_basebackup.pl is pushing a thousand lines and it's got a ton of unrelated tests in there already. The test included here fails on master, but passes with the patch. -- Robert Haas EDB: http://www.enterprisedb.com
v2-0001-Fix-pg_basebackup-with-in-place-tablespaces-some-.patch
Description: Binary data