On Thu, Mar 16, 2023 at 10:40 AM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > > On Thu, Mar 16, 2023 at 7:20 AM Peter Smith <smithpb2...@gmail.com> wrote: > > > > PSA v4 which addresses both of your review comments. > > Looks like a reasonable change to me. > > A nitpick: how about using rbtxn_get_toptxn instead of an explicit > variable toptxn for single use? >
I find all three suggestions are similar. Personally, I think the current code looks better. The v4 patch LGTM and I am planning to commit it unless there are more comments or people find your suggestions as an improvement. -- With Regards, Amit Kapila.
