Agree with your points Nathan. Just a headup.
On 14/03/23 03:10, Nathan Bossart wrote:
On Sat, Mar 11, 2023 at 09:41:18AM +0000, Ankit Kumar Pandey wrote:
1. In list_member_ptr, will it be okay to bring `const ListCell *cell` from
#ifdef USE_NO_SIMD
const ListCell *cell;
#endif
to #else like as mentioned below? This will make visual separation between #if
cases more cleaner
I would expect to see -Wdeclaration-after-statement warnings if we did
this.
This worked fine for me, no warnings on gcc 12.2.0. Not a concern though.
Thanks,
Ankit
