On Wed, 15 Mar 2023 at 02:57, Melanie Plageman <melanieplage...@gmail.com> wrote: > > > Subject: [PATCH v3 3/3] add vacuum option to specify ring_size and guc > > > > > #define INT_ACCESS_ONCE(var) ((int)(*((volatile int *)&(var)))) > > > +#define bufsize_limit_to_nbuffers(bufsize) (bufsize * 1024 / BLCKSZ) > > > > Macros are normally be capitalized > > Yes, there doesn't seem to be a great amount of consistency around > this... See pgstat.c read_chunk_s and bufmgr.c BufHdrGetBlock and > friends. Though there are probably more capitalized than not. Since it > does a bit of math and returns a value, I wanted to convey that it was > more like a function. Also, since the name was long, I thought all-caps > would be hard to read. However, if you or others feel strongly, I am > attached neither to the capitalization nor to the name at all (what do > you think of the name?).
A static inline function seems like a less surprising and more type safe solution for this. -- Ants Aasma Senior Database Engineer www.cybertec-postgresql.com
