Hi, Please see the attached patch.
Takamichi Osumi (Fujitsu) <osumi.takami...@fujitsu.com>, 14 Mar 2023 Sal, 18:20 tarihinde şunu yazdı: > (1) create_subscription.sgml > > + column types as opposed to text format. Even when this option > is enabled, > + only data types having binary send and receive functions will be > + transferred in binary. Note that the initial synchronization > requires > > (1-1) > > I think it's helpful to add a reference for the description about send and > receive functions (e.g. to the page of CREATE TYPE). > Done. > > (1-2) > > Also, it would be better to have a cross reference from there to this doc > as one paragraph probably in "Notes". I suggested this, because send and > receive functions are described as "optional" there and missing them leads > to error in the context of binary table synchronization. > I'm not sure whether this is necessary. In case of missing send/receive functions, error logs are already clear about what's wrong and logical replication docs also explain what could go wrong with binary. > (3) copy_table() > > + /* > + * If the publisher version is earlier than v14, it COPY command > doesn't > + * support the binary option. > + */ > > This sentence doesn't look correct grammatically. We can replace "it COPY > command" with "subscription" for example. Kindly please fix it. > Changed this with Amit's suggestion [1]. [1] https://www.postgresql.org/message-id/CAA4eK1%2BC7ykvdBxh_t1BdbX5Da1bM1BgsE%3D-i2koPkd3pSid0A%40mail.gmail.com Thanks, -- Melih Mutlu Microsoft
v14-0001-Allow-logical-replication-to-copy-table-in-binary.patch
Description: Binary data
