Hi Amit, all
Amit Kapila <amit.kapil...@gmail.com>, 14 Mar 2023 Sal, 09:50 tarihinde şunu yazdı: > On Mon, Mar 13, 2023 at 7:46 PM Önder Kalacı <onderkal...@gmail.com> > wrote: > > > > Attaching v47. > > > > I have made the following changes in the attached patch (a) removed > the function IsIdxSafeToSkipDuplicates() and used the check directly > in the caller Should be fine, we can re-introduce this function when I work on the non-pkey/RI unique index improvement as a follow up to this. > ; (b) changed a few comments in the patch; Thanks, looks good. > (c) the test > file was inconsistently using ';' while executing statement with > safe_psql, changed it to remove ';'. > > Alright, thanks. And as a self-review, when I write regression tests next time, I'll spend a lot more time on the style/consistency/comments etc. During this review, the reviewers had to spend many cycles on that area, which is something I should have done better. Attaching v49 with some minor changes Shi Yu noted earlier. Thanks, Onder KALACI
v49-0001-Allow-the-use-of-indexes-other-than-PK-and-REPLI.patch
Description: Binary data
