Hi Amit, all
> I'll look for more opportunities and reply to the thread. I wanted to send > this mail so that you can have a look at (1) earlier. > > > I merged SUBSCRIPTION CREATE/DROP INDEX WORKS WITHOUT ISSUES into SUBSCRIPTION CAN USE INDEXES WITH EXPRESSIONS AND COLUMNS. Also, merged SUBSCRIPTION USES INDEX WITH PUB/SUB DIFFERENT DATA and A UNIQUE INDEX THAT IS NOT PRIMARY KEY OR REPLICA IDENTITY So, we have 6 test cases left. I start to feel that trying to merge further is going to start making the readability get worse. Do you have any further easy test case merge suggestions? I think one option could be to drop some cases altogether, but not sure we'd want that. As a semi-related question: Are you aware of any setting that'd make pg_stat_all_indexes reflect the changes sooner? It is hard to debug what is the bottleneck in the tests, but I have a suspicion that there might be several poll_query_until() calls on pg_stat_all_indexes, which might be the reason? Attaching v43.
v43_0002_use_index_on_subs_when_pub_rep_ident_full.patch
Description: Binary data
v43_0001_Skip-dropped_columns_for_tuples_equal.patch
Description: Binary data
