On Thu, Mar 9, 2023 at 7:34 AM Kyotaro Horiguchi <horikyota....@gmail.com> wrote: > > > In short, my choice would still be simplicity here with v3, I guess. > > FWIW, I slightly prefer v3 for the reason I mentioned above.
Hm, then, +1 for v3. FWIW, I quickly tried to hit that case where a single WAL record has max_block_id = XLR_MAX_BLOCK_ID with both FPIs and block data, but I couldn't. I could generate WAL records with 45K FPIs, 10mn block data and the total palloc'd length in the block_id for loop has not crossed 8K. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
