Okay, I've added this to the next commitfest at https://commitfest.postgresql.org/18/1629/.
Thanks both Michael and David for the feedback so far. On 14 May 2018 at 02:37, Michael Paquier <mich...@paquier.xyz> wrote: > On Sun, May 13, 2018 at 07:01:00PM -0400, David Steele wrote: > > This patch makes sense to me and looks reasonable. > > One "potential" problem is if a relation has a full set of column which > allows the input of text-like data: if the header has been added with > COPY TO, and that the user forgets to add again the header option with > COPY FROM, then an extra row will be generated but there is the same > problem with CSV format :) > > One comment I have about the patch is that there is no test for > COPY FROM with an output file which has a header. In this case if > HEADER is true then the file can be loaded. If HEADER is wrong, an > error should normally be raised because of the format (well, let's > discard the case of the relation with text-only columns). So the tests > could be extended a bit even for CSV. > > > We're in the middle of a feature freeze that will last most of the > > summer, so be sure to enter your patch into the next commitfest so it > > can be considered when the freeze is over. > > > > https://commitfest.postgresql.org/18/ > > Yes, you will need to be patient a couple of months here. > -- > Michael >
