On Thu, Feb 16, 2023 at 11:00:20AM -0800, Andres Freund wrote: > I don't really understand this bit?
As of this message, I saw this quote: https://www.postgresql.org/message-id/fcalj2acxebwy_bm3kmzekypcxsm+ygitpyhi4fdt6msk6yrt...@mail.gmail.com "However, it increases the number of iovec initialization with zerobuf for the cases when pg_pwrite_zeros is called for sizes far greater than BLCKSZ (for instance, WAL file initialization)." But it looks like I misunderstood what this quote meant compared to what v3 does. It is true that v3 sets iov_len and iov_base more than needed when writing sizes larger than BLCKSZ. Seems like you think that it is not really going to matter much to track which iovecs have been already initialized during the first loop on pg_pwritev_with_retry() to keep the code shorter? -- Michael
signature.asc
Description: PGP signature
