Tomas Vondra <tomas.von...@enterprisedb.com> writes: > On 2/7/23 18:08, Paul Ramsey wrote: >> >> >>> On Feb 7, 2023, at 6:47 AM, Dag Lem <d...@nimrod.no> wrote: >>> >>> I just went by to check the status of the patch, and I noticed that >>> you've added yourself as reviewer earlier - great! >>> >>> Please tell me if there is anything I can do to help bring this across >>> the finish line. >> >> Honestly, I had set it to Ready for Committer, but then I went to >> run regression one more time and my regression blew up. I found I >> couldn't enable the UTF tests without things failing. And I don't >> blame you! I think my installation is probably out-of-alignment in >> some way, but I didn't want to flip the Ready flag without having >> run everything through to completion, so I flipped it back. Also, >> are the UTF tests enabled by default? It wasn't clear to me that >> they were? >> > The utf8 tests are enabled depending on the encoding returned by > getdatabaseencoding(). Systems with other encodings will simply use the > alternate .out file. And it works perfectly fine for me. > > IMHO it's ready for committer. > > > regards
Yes, the UTF-8 tests follow the current best practice as has been explained to me earlier. The following patch exemplifies this: https://github.com/postgres/postgres/commit/c2e8bd27519f47ff56987b30eb34a01969b9a9e8 Best regards, Dag Lem
