Hi, Scanning ExecInsert, it looks like there's a needless additional partition constraint check against the tuple. This should only be required if there's a before row INSERT trigger. The code block up one from the additional check tries to disable the check, but it goes ahead regardless, providing there's some other constraint.
ExecFindPartition should have already located the correct partition and nothing should have changed in the absence of before row insert triggers, so it looks like we're fine to not bother re-checking. Or did I misunderstand? -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
remove_needless_additional_partition_check.patch
Description: Binary data
