Hi, > From 098f37c0a17fc32a94bff43817414e01fcfb234f Mon Sep 17 00:00:00 2001 > From: Rishu Bagga <bagri...@amazon.com> > Date: Thu, 15 Sep 2022 00:55:25 +0000 > Subject: [PATCH] slru to buffercache + page headers + upgrade > > --- > contrib/amcheck/verify_nbtree.c | 2 +- > [...] > 65 files changed, 2176 insertions(+), 3258 deletions(-)
Unfortunately a quite large patch, with this little explanation, is hard to review. I could read through the entire thread to try to figure out what this is doing, but I really shouldn't have to. You're changing quite fundamental APIs across the tree. Why is that required for the topic at hand? Why is it worth doing that, given it'll break loads of extensions? Greetings, Andres Freund
