On 2023-02-04 Sa 09:20, Andrew Dunstan wrote:
On 2023-02-04 Sa 06:34, Andres Freund wrote:ISTM that we're closer to being able to enforce pgindent than perltidy. At the same time, I think the issue of C code in HEAD not being indented is more pressing - IME it's much more common to have to touch a lot of C code than to have to touch a lot fo perl files. So perhaps we should just start with being more stringent with C code, and once we made perltidy less noisy, add that?Sure, we don't have to tie them together.I'm currently experimenting with settings on the buildfarm code, trying to get it both stable and looking nice. Then I'll try on the Postgres core code and post some results.
So here's a diff made from running perltidy v20221112 with the additional setting --valign-exclusion-list=", = => || && if unless"
Essentially this abandons those bits of vertical alignment that tend to catch us out when additions are made to the code.
I think this will make the code much more maintainable and result in much less perltidy churn. It would also mean that it's far more likely that what we would naturally code can be undisturbed by perltidy.
cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com
pgperltidy-no-valign.patch.gz
Description: application/gzip
