Andres Freund <and...@anarazel.de> writes:
> On 2023-02-01 12:23:27 -0500, Tom Lane wrote:
>> It's unlike what "make -C doc/src/sgml all" does in the Makefile
>> system, and I don't find it to be an improvement.
> Well, that'd actually build the manpages too, afaics :). But I get the
> point.
Ah, sorry, I too had forgotten that "all" isn't the default target
there. I actually just go into that directory and type "make".
> I really have no opinion on what we should should build under what
> name. Happy to change what's included in 'docs', add additional targets,
> etc.
I think "docs" for just the html and "alldocs" for all supported
outputs is probably reasonable. If we ever get to the point of
building distribution tarballs with meson, we might need another
target for html+man, but I suppose that's a long way off.
>> And the minimum version appears to be newer than RHEL8's 1.8.2, which
>> I find pretty unfortunate. On RHEL8, it fails with
>> $ ninja
>> ninja: error: build.ninja:6771: multiple outputs aren't (yet?) supported by
>> depslog; bring this up on the mailing list if it affects you
> What's in that line +- 2 lines? And/or what are the steps that got you
> to that point?
"meson setup build" is sufficient to see it --- apparently ninja
gets invoked at the end of that, and it's already unhappy. But
it repeats after "cd build; ninja".
It seems to be unhappy about the stanza for building sql_help.c?
Line 6771 is the blank line after "description" in this bit:
build src/bin/psql/sql_help.c src/bin/psql/sql_help.h: CUSTOM_COMMAND_DEP |
../src/bin/psql/create_help.pl /usr/bin/perl
DEPFILE = src/bin/psql/sql_help.dep
DEPFILE_UNQUOTED = src/bin/psql/sql_help.dep
COMMAND = /usr/bin/perl ../src/bin/psql/create_help.pl --docdir
../doc/src/sgml/ref --depfile src/bin/psql/sql_help.dep --outdir src/bin/psql
--basename sql_help
description = Generating$ psql_help$ with$ a$ custom$ command
build src/bin/psql/psql.p/meson-generated_.._psqlscanslash.c.o: c_COMPILER
src/bin/psql/psqlscanslash.c || src/bin/psql/sql_help.h
src/include/catalog/pg_aggregate_d.h src/include/catalog/pg_am_d.h
src/include/catalog/pg_amop_d.h src/include/catalog/pg_amproc_d.h
src/include/catalog/pg_attrdef_d.h src/include/catalog/pg_attribute_d.h
src/include/catalog/pg_auth_members_d.h src/include/catalog/pg_authid_d.h
src/include/catalog/pg_cast_d.h src/include/catalog/pg_class_d.h
src/include/catalog/pg_collation_d.h src/include/catalog/pg_constraint_d.h
src/include/catalog/pg_conversion_d.h src/include/catalog/pg_database_d.h
src/include/catalog/pg_db_role_setting_d.h
src/include/catalog/pg_default_acl_d.h src/include/catalog/pg_depend_d.h
src/include/catalog/pg_description_d.h src/include/catalog/pg_enum_d.h
src/include/catalog/pg_event_trigger_d.h src/include/catalog/pg_extension_d.h
src/include/catalog/pg_foreign_data_wrapper_d.h
src/include/catalog/pg_foreign_server_d.h
src/include/catalog/pg_foreign_table_d.h src/include/catalog/pg_index_d.h
src/include/catalog/pg_inherits_d.h src/include/catalog/pg_init_privs_d.h
src/include/catalog/pg_language_d.h src/include/catalog/pg_largeobject_d.h
src/include/catalog/pg_largeobject_metadata_d.h
src/include/catalog/pg_namespace_d.h src/include/catalog/pg_opclass_d.h
src/include/catalog/pg_operator_d.h src/include/catalog/pg_opfamily_d.h
src/include/catalog/pg_parameter_acl_d.h
src/include/catalog/pg_partitioned_table_d.h src/include/catalog/pg_policy_d.h
src/include/catalog/pg_proc_d.h src/include/catalog/pg_publication_d.h
src/include/catalog/pg_publication_namespace_d.h
src/include/catalog/pg_publication_rel_d.h src/include/catalog/pg_range_d.h
src/include/catalog/pg_replication_origin_d.h
src/include/catalog/pg_rewrite_d.h src/include/catalog/pg_seclabel_d.h
src/include/catalog/pg_sequence_d.h src/include/catalog/pg_shdepend_d.h
src/include/catalog/pg_shdescription_d.h src/include/catalog/pg_shseclabel_d.h
src/include/catalog/pg_statistic_d.h src/include/catalog/pg_statistic_ext_d.h
src/include/catalog/pg_statistic_ext_data_d.h
src/include/catalog/pg_subscription_d.h
src/include/catalog/pg_subscription_rel_d.h
src/include/catalog/pg_tablespace_d.h src/include/catalog/pg_transform_d.h
src/include/catalog/pg_trigger_d.h src/include/catalog/pg_ts_config_d.h
src/include/catalog/pg_ts_config_map_d.h src/include/catalog/pg_ts_dict_d.h
src/include/catalog/pg_ts_parser_d.h src/include/catalog/pg_ts_template_d.h
src/include/catalog/pg_type_d.h src/include/catalog/pg_user_mapping_d.h
src/include/catalog/postgres.bki src/include/catalog/schemapg.h
src/include/catalog/system_constraints.sql src/include/catalog/system_fk_info.h
src/include/nodes/nodetags.h src/include/utils/errcodes.h
DEPFILE = src/bin/psql/psql.p/meson-generated_.._psqlscanslash.c.o.d
DEPFILE_UNQUOTED = src/bin/psql/psql.p/meson-generated_.._psqlscanslash.c.o.d
ARGS = -Isrc/bin/psql/psql.p -Isrc/bin/psql -I../src/bin/psql -Isrc/include
-I../src/include -Isrc/interfaces/libpq -I../src/interfaces/libpq
-fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O3
-fno-strict-aliasing -fwrapv -fexcess-precision=standard -D_GNU_SOURCE
-Wmissing-prototypes -Wpointer-arith -Werror=vla -Wendif-labels
-Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type
-Wshadow=compatible-local -Wformat-security -Wdeclaration-after-statement
-Wno-format-truncation -Wno-stringop-truncation -pthread
>> I did manage to test this stuff on bleeding-edge Fedora,
>> but ...
> Yea, I worked a fair bit to avoid requiring a too new version, I'll try
> to figure out what went wrong. I did built on rhel8 not long ago, so I
> suspect it's a corner case somewhere.
Oh, interesting. Let me know if you want me to test anything in
particular.
regards, tom lane
