On Tue, Jan 24, 2023 at 5:02 AM Euler Taveira <eu...@eulerto.com> wrote: > > On Sun, Jan 22, 2023, at 9:42 AM, Takamichi Osumi (Fujitsu) wrote: > > > Attached the updated patch v19. > > [I haven't been following this thread for a long time...] > > Good to know that you keep improving this patch. I have a few suggestions that > were easier to provide a patch on top of your latest patch than to provide an > inline suggestions. >
Euler, thanks for your comments. We have an existing problem related to shutdown which impacts this patch. The problem is that during shutdown on the publisher, we wait for all the WAL to be sent and flushed on the subscriber. Now, if we user has configured a long value for min_apply_delay on the subscriber then the shutdown won't be successful. This can happen even today if the subscriber waits for some lock during the apply. This is not so much a problem with physical replication because there we have a separate process to first flush the WAL. This problem has been discussed in a separate thread as well. See [1]. It is important to reach conclusion even if we just want to document it. So, your thoughts on that other thread can help us to make it move forward. [1] - https://www.postgresql.org/message-id/TYAPR01MB586668E50FC2447AD7F92491F5E89%40TYAPR01MB5866.jpnprd01.prod.outlook.com -- With Regards, Amit Kapila.
