On Wed, Jan 18, 2023 at 6:27 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Sat, Jan 7, 2023 at 8:58 PM Zheng Li <zhengl...@gmail.com> wrote: > > > > I added documentation and changed user interface design in the > > attached v60 patch set. > > The patch set addressed comments from Peter in [1]. > > > > The motivation for the user interface change is that we want to manage > > DDL replication feature in stages with fine grained replication > > levels. > > For example, we can focus on reviewing and testing table commands > > first, then other commands. It also make sense to introduce different > > DDL replication levels > > from the user perspective as pointed out in [1]. We can add more > > replication levels along the way. > > > > In this patch DDL replication is disabled by default and it can be > > enabled at different levels > > using the new PUBLICATION option 'ddl'. This option currently has two > > levels and are > > only allowed to be set if the PUBLICATION is FOR ALL TABLES. > > > > all: this option enables replication of all supported DDL commands. > > table: this option enables replication of Table DDL commands which > > include: > > -CREATE/ALTER/DROP TABLE > > -CREATE TABLE AS > > > > I think this point needs some thought. When you say 'all', how do you > think it will help to support DDL replication for foreign tables, > materialized views, views, etc where changes to such relations are > currently not supported by logical replication?
I think DDL replication naturally provides support for views and materialized views, if the publication is FOR ALL TABLES since all the tables in the view/MV definition are replicated. Foreign Tables can also be considered replicated with DDL replication because we don't even need to replicate the data as it resides on the external server. Users need to configure the external server to allow connection from the subscriber for foreign tables to work on the subscriber. > We should also think > about initial sync for all those objects as well. Agree, we're starting an investigation on initial sync. But I think initial sync depends on DDL replication to work reliably, not the other way around. DDL replication can work on its own without the initial sync of schema, users just need to setup the initial schema just like they would today. Regards, Znae
