On Tue, Jan 17, 2023 at 6:41 PM Ashutosh Bapat <ashutosh.bapat....@gmail.com> wrote: > > On Tue, Jan 17, 2023 at 3:34 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > > I am a bit worried about the indirections that the wrappers and hooks > > > create. Output plugins call OutputPluginUpdateProgress() in callbacks > > > but I don't see why ReorderBufferProcessTXN() needs a callback to > > > call OutputPluginUpdateProgress. > > > > > > > Yeah, I think we can do it as we are doing the previous approach but > > we need an additional wrapper (update_progress_cb_wrapper()) as the > > current patch has so that we can add error context information. This > > is similar to why we have a wrapper for all other callbacks like > > change_cb_wrapper. > > > > Ultimately OutputPluginUpdateProgress() will be called - which in turn > will call ctx->update_progress. >
No, update_progress_cb_wrapper() should directly call ctx->update_progress(). The key reason to have a update_progress_cb_wrapper() is that it allows us to add error context information (see the usage of output_plugin_error_callback). -- With Regards, Amit Kapila.
