On Tue, 17 Jan 2023 at 13:16, Dean Rasheed <dean.a.rash...@gmail.com> wrote: > > On Wed, 11 Jan 2023 at 05:24, David Rowley <dgrowle...@gmail.com> wrote: > > > > I'm wondering if 1349d279 should have just never opted to presort > > Aggrefs which have volatile functions so that the existing behaviour > > of unordered output is given always and nobody is fooled into thinking > > this works correctly only to be disappointed later when they add some > > other aggregate to their query or if we should fix both. Certainly, > > it seems much easier to do the former. > > > > I took a look at this, and I agree that the best solution is probably > to have make_pathkeys_for_groupagg() ignore Aggrefs that contain > volatile functions.
Thanks for giving that some additional thought. I've just pushed a fix which adjusts things that way. David
