On Tue, Jan 10, 2023 at 3:05 PM Andres Freund <and...@anarazel.de> wrote: > On 2023-01-03 12:05:20 -0800, Andres Freund wrote: > > The attached patch adds libpq-be-fe-helpers.h and uses it in > > libpqwalreceiver, > > dblink, postgres_fdw. > > > As I made libpq-be-fe-helpers.h handle reserving external fds, > > libpqwalreceiver now does so. I briefly looked through its users without > > seeing cases of leaking in case of errors - which would already have been > > bad, > > since we'd already have leaked a libpq connection/socket. > > > > > > Given the lack of field complaints and the size of the required changes, I > > don't think we should backpatch this, even though it's pretty clearly buggy > > as-is. > > Any comments on this? Otherwise I think I'll go with this approach.
+1. Not totally convinced about the location but we are free to re-organise it any time, and the random CI failures are bad.
