On Friday, January 13, 2023 2:20 PM Peter Smith <smithpb2...@gmail.com> wrote: > > Here are some review comments for patch v79-0002.
Thanks for your comments. > ====== > > General > > 1. > > I saw that earlier in this thread Hou-san [1] and Amit [2] also seemed to say > there is not much point for this patch. > > So I wanted to +1 that same opinion. > > I feel this patch just adds more complexity for almost no gain: > - reducing the 'max_apply_workers_per_suibscription' seems not very > common in the first place. > - even when the GUC is reduced, at that point in time all the workers might > be in > use so there may be nothing that can be immediately done. > - IIUC the excess workers (for a reduced GUC) are going to get freed naturally > anyway over time as more transactions are completed so the pool size will > reduce accordingly. I need to think over it, and we can have detailed discussion after committing the first patch. So I didn't address the comments for 0002 for now. Best Regards, Hou zj
