On 09.01.23 21:18, Tom Lane wrote:
* AFAIK our practice is to use "-" never "_" in XML ID attributes. You weren't very consistent about that even within this patch, and the overall effect would have been to have no standard about that at all, which doesn't seem great. I changed them all to "-".
In the olden says, "_" was invalid in ID attribute values. This is no longer the case. But of course it's good to stay consistent with existing practice where reasonable.