Tom Lane wrote: > However, RenameTempFile is also used by Gen_fmgrtab.pl, and having the > same sort of no-touch semantics for fmgroids.h and friends would have some > additional fallout. The makefiles would think they have to keep > re-running Gen_fmgrtab.pl if fmgroids.h is older than the mod time on any > input file, and that's certainly no good. We can fix that by inventing a > stamp file for the Gen_fmgrtab.pl run, analogous to bki-stamp for the > genbki.pl run, but that means changes in the makefiles that go a bit > beyond the realm of triviality.
Sounds OK to me -- a stamp file is already established technique, so it shouldn't go *too much* beyond triviality. I do note that msvc/Solution.pm runs Gen_fmgrtab.pl, but it shouldn't require any changes anyhow. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
