On Tue, Jan 3, 2023 at 10:52 PM Peter Geoghegan <p...@bowt.ie> wrote: > > And it'd make sense to have > > the explanation of why TransactionIdDidAbort() isn't the same as > > !TransactionIdDidCommit(), even for !TransactionIdIsInProgress() xacts, near > > the explanation for doing TransactionIdIsInProgress() first. > > I think that we should definitely have a comment directly over > TransactionIdDidAbort(). Though I wouldn't mind reorganizing these > other comments, or making the comment over TransactionIdDidAbort() > mostly just point to the other comments.
What do you think of the attached patch, which revises comments over TransactionIdDidAbort, and adds something about it to the top of heapam_visbility.c? -- Peter Geoghegan
v1-0001-Document-TransactionIdDidAbort-hard-crash-behavio.patch
Description: Binary data
