On Thu, May 3, 2018 at 2:30 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Do you really need the pg_crc32c_armv8_choose_dummy global variable? > That seems pretty ugly. If you're concerned about the compiler > optimizing away the call to the crc function, you could write it like > > result = (pg_comp_crc32c_armv8(0, 0, 0) == expected-value); > > which'd provide a bit of extra checking that the code's not broken, > too.
True. Of course I needed an interesting length too... -- Thomas Munro http://www.enterprisedb.com
0001-Use-a-portable-way-to-detect-ARMv8-CRC32-hardware-v2.patch
Description: Binary data
