On 23.12.22 14:01, David Rowley wrote:
Maybe if there's concern that inlining appendStringInfoString is going to bloat the binary too much, then how about we just invent an inlined version of it using some other name that we can use when performance matters? We could then safely replace the offending appendBinaryStringInfos from both places without any concern for regressing performance.
The jsonpath output routines don't appear to be written with deep concern about performance now, so I'm not sure this is the place to start tweaking. For the jsonb parts, there are only a handful of strings this affects ("true", "false", "null"), so using appendBinaryStringInfo() there a few times doesn't seem so bad. So I'm not too worried about this altogether.
