On Mon, Dec 26, 2022 21:02 PM Masahiko Sawada <sawada.m...@gmail.com> wrote:
> Thank you for updating the patches. Here are some comments for 0001
> and 0002 patches:
Thanks for your comments.
> I think it'd be better to write logs when the leader enters the
> serialization mode. It would be helpful for investigating issues.
Agree. Added the log about this in the function pa_send_data().
> ---
> +static inline bool
> +am_leader_apply_worker(void)
> +{
> + return (!OidIsValid(MyLogicalRepWorker->relid) &&
> + !isParallelApplyWorker(MyLogicalRepWorker));
> +}
>
> How about using !am_tablesync_worker() instead of
> !OidIsValid(MyLogicalRepWorker->relid) for better readability?
Agree. Improved this as suggested.
The new patch set was attached in [1].
[1] -
https://www.postgresql.org/message-id/OS3PR01MB6275B61076717E4CE9E079D19EED9%40OS3PR01MB6275.jpnprd01.prod.outlook.com
Regards,
Wang wei
