Hi, On 2022-12-03 09:41:04 -0800, Andrey Borodin wrote: > Fixed. Added test for this.
The tests don't pass: https://cirrus-ci.com/build/4811553145356288 [00:54:35.337](1.251s) not ok 1 - no parameters missing from postgresql.conf.sample [00:54:35.338](0.000s) # Failed test 'no parameters missing from postgresql.conf.sample' # at /tmp/cirrus-ci-build/src/test/modules/test_misc/t/003_check_guc.pl line 81. [00:54:35.338](0.000s) # got: '1' # expected: '0' I am just looking through a bunch of failing CF entries, so I'm perhaps over-sensitized right now. But I'm a bit confused why there's so many occasions of the tests clearly not having been run... Michael, any reason 003_check_guc doesn't show the missing GUCs? It's not particularly helpful to see "0 is different from 1". Seems that even just something like is_deeply(\@missing_from_file, [], "no parameters missing from postgresql.conf.sample"); would be a decent improvement? Greetings, Andres Freund
