Hi Ian, Ian Lawrence Barwick <barw...@gmail.com> writes:
> Hi Dag > > 2022年2月3日(木) 23:27 Dag Lem <d...@nimrod.no>: >> >> Hi, >> >> Just some minor adjustments to the patch: >> >> * Removed call to locale-dependent toupper() >> * Cleaned up input normalization > > This patch was marked as "Waiting on Author" in the CommitFest entry [1] > but I see you provided an updated version which hasn't received any feedback, > so I've move this to the next CommitFest [2] and set it to "Needs Review". > > [1] https://commitfest.postgresql.org/40/3451/ > [2] https://commitfest.postgresql.org/41/3451/ > >> I have been asked to sign up to review a commitfest patch or patches - >> unfortunately I've been ill with COVID-19 and it's not until now that >> I feel well enough to have a look. >> >> Julien: I'll have a look at https://commitfest.postgresql.org/36/3468/ >> as you suggested (https://commitfest.postgresql.org/36/3379/ seems to >> have been reviewed now). >> >> If there are other suggestions for a patch or patches to review for >> someone new to PostgreSQL internals, I'd be grateful for that. > > I see you provided some feedback on > https://commitfest.postgresql.org/36/3468/, > though the patch seems to have not been accepted (but not conclusively > rejected > either). If you still have the chance to review another patch (or more) it > would > be much appreciated, as there's quite a few piling up. Things like > documentation > or small improvements to client applications are always a good place to start. > Reviews can be provided at any time, there's no need to wait for the next > CommitFest. > OK, I'll try to find another patch to review. Regards Dag Lem
