Hi all, apologies the patch was rushed too quickly - my bad. I'm attaching a fixed one as v0004 (as it is the 4th patch floating around here).
-Jakub Wartak On Mon, Nov 21, 2022 at 9:55 PM Robert Haas <robertmh...@gmail.com> wrote: > > On Mon, Nov 21, 2022 at 1:17 PM Andres Freund <and...@anarazel.de> wrote: > > On November 21, 2022 9:37:34 AM PST, Robert Haas <robertmh...@gmail.com> > > wrote: > > >On Mon, Nov 21, 2022 at 12:30 PM Andres Freund <and...@anarazel.de> wrote: > > >> This can't quite be right - isn't this only applying the limit if we > > >> found a > > >> visible tuple? > > > > > >It doesn't look that way to me, but perhaps I'm just too dense to see > > >the problem? > > > > The earlier version didn't have the issue, but the latest seems to only > > limit after a visible tuple has been found. Note the continue; when > > fetching a heap tuple fails. > > Oh, that line was removed in Simon's patch but not in Jakub's version, > I guess. Jakub's version also leaves out the last_block = block line > which seems pretty critical. > > -- > Robert Haas > EDB: http://www.enterprisedb.com
0001-Damage-control-for-planner-s-get_actual_variable_end_v0004.patch
Description: Binary data
