Hi all, While reviewing a different patch, I have noticed that guc-file.l includes sys/stat.h in the middle of the PG internal headers. The usual practice is to have first postgres[_fe].h, followed by the system headers and finally the internal headers. That's a nit, but all the other files do that.
{be,fe}-secure-openssl.c include some exceptions though, as documented
there.
Thoughts?
--
Michael
diff --git a/src/backend/utils/misc/guc-file.l b/src/backend/utils/misc/guc-file.l index 2436396306..caa9c902b9 100644 --- a/src/backend/utils/misc/guc-file.l +++ b/src/backend/utils/misc/guc-file.l @@ -10,6 +10,7 @@ #include "postgres.h" #include <ctype.h> +#include <sys/stat.h> #include <unistd.h> #include "common/file_utils.h" @@ -17,7 +18,6 @@ #include "mb/pg_wchar.h" #include "miscadmin.h" #include "storage/fd.h" -#include <sys/stat.h> #include "utils/memutils.h" }
signature.asc
Description: PGP signature
