On Tue, Nov 01, 2022 at 05:33:24PM +0800, Richard Guo wrote: > On Mon, Oct 31, 2022 at 1:33 PM Michael Paquier <mich...@paquier.xyz> wrote: > > > On Mon, Oct 31, 2022 at 01:12:09PM +0800, Richard Guo wrote: > > > BTW, I noticed a micro-optimization opportunity in examine_variable that > > > we can fetch the RangeTblEntry for 'onerel' outside the foreach loop > > > when iterating the extended stats so that we can do it only once rather > > > than for each stat. > > > > Isn't that the kind of thing where we'd better have some regression > > coverage? > > Yeah, we need to have some regression tests for that. I come up with a > case in stats_ext like below
Well done > This case should be able to cover both expression stats and ndistinct > stats. Hence, attach v2 patch. Thanks for finishing it up. I added a CF entry and marked RFC. This should be included in v15.1. -- Justin
