On Mon, Oct 31, 2022 at 4:51 PM Andres Freund <and...@anarazel.de> wrote:
> Hi, > > On 2022-10-31 16:21:06 +0530, Bharath Rupireddy wrote: > > BTW, I've seen a sporadic crash (SEGV) with the patch in bg writer > > with the same set up [1], I'm not sure if it's really because of the > > patch. I'm unable to reproduce it now and unfortunately I didn't > > capture further details when it occurred. > > That's likely because the prototype patch I submitted in this thread missed > updating LWLockUpdateVar(). > > Updated patch attached. > > Greetings, > > Andres Freund > Hi, Minor comment: + uint8 lwWaiting; /* see LWLockWaitState */ Why not declare `lwWaiting` of type LWLockWaitState ? Cheers
