On Mon, Oct 24, 2022 at 11:42:58AM +0900, Kyotaro Horiguchi wrote: > At Sat, 22 Oct 2022 09:56:06 +0200, Alvaro Herrera <alvhe...@alvh.no-ip.org> > wrote in >> My intention here was that the Assert should be inside the block, that >> is, we already know that at least one is true, and we want to make sure >> that they are not *both* true. >> >> AFAICT the attached patch also fixes the bug without making the assert >> weaker.
On the contrary, it seems to me that putting the assertion within the if() block makes the assertion weaker, because we would never check for an incorrect state after do_pg_abort_backup() is registered (aka any pg_backup_start() call) when not entering in this if() block. Saying that, if you feel otherwise I am fine with your conclusion as well, so feel free to solve this issue as you see fit. :p -- Michael
signature.asc
Description: PGP signature
