On Thu, Oct 20, 2022 at 3:10 AM Andres Freund <and...@anarazel.de> wrote: > > Hi, > > While reviewing > https://postgr.es/m/CAD21AoBe2o2D%3Dxyycsxw2bQOD%3DzPj7ETuJ5VYGN%3DdpoTiCMRJQ%40mail.gmail.com > I noticed that pg_recvlogical prints > "pg_recvlogical: error: unexpected termination of replication stream: " > > when signalled with SIGINT/TERM. > > Oddly enough, that looks to have "always" been the case, even though clearly > the code tried to make provisions for a different outcome. > > > It looks to me like all that's needed is to gate the block printing the > message with an !time_to_abort.
+1. How about emitting a message like its friend pg_receivewal, like the attached patch? > I also then noticed that we don't fsync the output file in cases of errors - > that seems wrong to me? Looks to me like that block should be moved till after > the error:? How about something like the attached patch? -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
v1-0001-pg_recvlogical-fixes.patch
Description: Binary data
