On Mon, Mar 07, 2022 at 05:09:23PM +0100, Matthias van de Meent wrote: > That's for the AM-internal flushing; yes. I was thinking about the AM > api for flushing that's used when finalizing the batched insert; i.e. > table_multi_insert_flush. > > Currently it assumes that all buffered tuples will be flushed after > one call (which is correct for heap), but putting those unflushed > tuples all at once back in memory might not be desirable or possible > (for e.g. columnar); so we might need to call table_multi_insert_flush > until there's no more buffered tuples.
This thread has been idle for 6 months now, so I have marked it as returned with feedback as of what looks like a lack of activity. I have looked at what's been proposed, and I am not really sure if the direction taken is correct, though there may be a potential gain in consolidating the multi-insert path within the table AM set of callbacks. -- Michael
signature.asc
Description: PGP signature
