On Tue, Oct 11, 2022 at 2:46 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Mon, Oct 10, 2022 at 8:14 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > > > > Peter Smith <smithpb2...@gmail.com> writes: > > > On Mon, Oct 10, 2022 at 4:04 PM Amit Kapila <amit.kapil...@gmail.com> > > > wrote: > > >> I think the below gives accurate information: > > >> WARNING: subscription was created, but is not connected > > >> HINT: You should create the slot manually, enable the subscription, > > >> and run %s to initiate replication. > > > > > +1 > > > > It feels a little strange to me that we describe two steps rather vaguely > > and then give exact SQL for the third step. How about, say, > > > > HINT: To initiate replication, you must manually create the replication > > slot, enable the subscription, and refresh the subscription. > > > > LGTM.
PSA patch v3-0001 where the message/hint is worded as suggested above > BTW, do we want to slightly adjust the documentation for the > connect option on CREATE SUBSCRIPTION page [1]? It says: "Since no > connection is made when this option is false, no tables are > subscribed, and so after you enable the subscription nothing will be > replicated. You will need to then run ALTER SUBSCRIPTION ... REFRESH > PUBLICATION for tables to be subscribed." > > It doesn't say anything about manually creating the slot and probably > the wording can be made similar. > PSA patch v3-0002 which changes CREATE SUBSCRIPTION pgdocs to use the same wording as in the HINT message. ------ Kind Regards, Peter Smith. Fujitsu Australia
v3-0002-create-subscription-pgdocs.patch
Description: Binary data
v3-0001-create-subscription-warning-message.patch
Description: Binary data
