On 2022-Oct-06, Zheng Li wrote: > Some tweaking is made in deparse_drop_command in order to make DROP > TRANSFORM deparsing work. This is because the objidentity captured in > currentEventTriggerState->SQLDropList contains the keyword 'on', for > example "for typename on language lang", but the keyword 'on' is not > needed in the current DROP TRANSFORM syntax. So we need to remove the > 'on' keyword in objidentity. I'm not sure if this is the best way to > handle it, maybe we can consider directly modifying what's captured in > currentEventTriggerState->SQLDropList > so we don't have the "on" keyword to begin with?
The exact output format for identity is not set in stone; we should only set it in stone once we have an actual working case for them. This is the first such use, so it seems OK to make minor modifications (such as removing an undesirable ON) if it's a reasonable change and allows consumer code to be more easily written. So, +1 to dropping ON here. However, if there are further strings that need to be modified, let's see what they are. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ <Schwern> It does it in a really, really complicated way <crab> why does it need to be complicated? <Schwern> Because it's MakeMaker.
