Em ter., 4 de out. de 2022 às 01:18, Michael Paquier <mich...@paquier.xyz> escreveu:
> On Mon, Oct 03, 2022 at 08:05:57AM -0300, Ranier Vilela wrote: > > Em seg., 3 de out. de 2022 às 05:01, Masahiko Sawada < > sawada.m...@gmail.com> > > escreveu: > >> On Fri, Sep 30, 2022 at 9:08 AM Ranier Vilela <ranier...@gmail.com> > wrote: > >>> 1. Avoid useless reassigning var _logsegno > >> (src/backend/access/transam/xlog.c) > >>> Commit 7d70809 left a little oversight. > >>> XLByteToPrevSeg and XLByteToSeg are macros, and both assign _logsegno. > >>> So, the first assignment is lost and is useless. > > Right, I have missed this one. We do that now in > build_backup_content() when building the contents of the backup > history file. > > >>> 4. Fix declaration volatile signal var (src/bin/pgbench/pgbench.c) > >>> Like how to commit 5ac9e86, this is a similar case. > >> > >> The same is true also for alarm_triggered in pg_test_fsync.c? > >> > > I don't think so. > > If I understand the problem correctly, the failure can occur with true > > signals, provided by the OS > > In the case at hand, it seems to me more like an internal form of signal, > > that is, simulated. > > So bool works fine. > > I am not following your reasoning here. Why does it matter to change > one but not the other? Both are used with SIGALRM, it seems. > Both are correct, I missed the pqsignal calls. Attached patch to change this. > The other three seem fine, so fixed. > Thanks Michael for the commit. regards, Ranier Vilela
fix_declaration_volatile_signal_pg_test_fsync.patch
Description: Binary data
