On 04.10.22 09:19, Bharath Rupireddy wrote:
We have the pg_attribute_unused() macro already. I'm not sure if adding -Wunused-parameter for compilation plus using pg_attribute_unused() for unused-yet-contextually-required variables is a great idea. But it has some merits as it avoids unused variables lying around in the code. However, we can even discuss this in a separate thread IMO to hear more from other hackers.
I tried this once. The patch I have from a few years ago is 420 files changed, 1482 insertions(+), 1482 deletions(-) and it was a lot of work to maintain. I can send it in if there is interest. But I'm not sure if it's worth it.
