On Tue, Oct 4, 2022 at 12:00 PM Peter Eisentraut <peter.eisentr...@enterprisedb.com> wrote: > > On 16.05.22 10:27, Peter Eisentraut wrote: > > Inspired by [0], I looked to convert more macros to inline functions. > > Here is another one from the same batch of work that I somehow didn't > send in last time. > I think assertion can be placed outside of the IF-block and braces can be removed.
> (IMO it's questionable whether this one should be an inline function or > macro at all, rather than a normal external function.) IMO, it should be inlined with RelationGetSmgr(). Regards, Amul